Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crate] Pass ChannelId by value instead of reference since it impls Copy #537

Closed
Farhad-Shabani opened this issue Mar 15, 2023 · 1 comment
Closed

[Crate] Pass ChannelId by value instead of reference since it impls Copy #537

Farhad-Shabani opened this issue Mar 15, 2023 · 1 comment
Labels
A: good-first-issue Admin: good for newcomers A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Mar 15, 2023 •
edited
Loading

Summary

Part of #25, originated from informalsystems/hermes#2071 (comment)

We should revisit the codebase and check wherever this comment applies pass the ChannelId by value instead of getting the reference since it impls the Copy
@Farhad-Shabani Farhad-Shabani mentioned this issue Mar 15, 2023
Closed
20 tasks
@Farhad-Shabani Farhad-Shabani moved this to 📥 To Do in ibc-rs Mar 15, 2023
@Farhad-Shabani Farhad-Shabani added the A: good-first-issue Admin: good for newcomers label Mar 15, 2023
@plafer plafer added the A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews label Mar 15, 2023
This was referenced Mar 16, 2023
Closed
Closed
@plafer
Copy link
Contributor

plafer commented Mar 22, 2023

See #542 (comment)

@plafer plafer closed this as completed Mar 22, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Mar 22, 2023
@plafer plafer closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: good-first-issue Admin: good for newcomers A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews
Projects
ibc-rs
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Pass ChannelId by value instead of reference since it impls Copy octopus-network/ibc-rs
2 participants
@plafer @Farhad-Shabani