Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ICS02] Examine removing dyn ValidationContext type from check_header_and_update_state() and check_misbehaviour_and_update_state() #534

Closed
Tracked by #554
Farhad-Shabani opened this issue Mar 15, 2023 · 0 comments · Fixed by #683
Labels
A: breaking Admin: breaking change that may impact operators O: decoupling Objective: aims to separate concerns and cause to independent, reusable components O: logic Objective: aims for better implementation logic

Comments

@Farhad-Shabani
Copy link
Member

Summary

Part of #25

Examine the possibility of moving away from passing dyn ValidationContext type at check_header_and_update_state() and check_misbehaviour_and_update_state()

Description

This requires us to pass a Sized object and restricts us from exploring more generic ideas (Like incorporating associated or generic types within ValidtionContext / Module / Router traits or using blanket implementation to get the needed interface available for objects that implement ClientState/ Module traits)
As well, it does not seem efficient to pass all the context while needed data comes in via one or two methods.

@Farhad-Shabani Farhad-Shabani added the O: logic Objective: aims for better implementation logic label Mar 15, 2023
@Farhad-Shabani Farhad-Shabani moved this to 📥 To Do in ibc-rs Mar 15, 2023
@Farhad-Shabani Farhad-Shabani added the O: decoupling Objective: aims to separate concerns and cause to independent, reusable components label Mar 15, 2023
@Farhad-Shabani Farhad-Shabani moved this from 📥 To Do to 🏗️ In Progress in ibc-rs Jun 26, 2023
@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label Jun 27, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in ibc-rs Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: breaking Admin: breaking change that may impact operators O: decoupling Objective: aims to separate concerns and cause to independent, reusable components O: logic Objective: aims for better implementation logic
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant