Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnOpenAck handler verifies incorrect counterparty ConnectionId #274

Closed
plafer opened this issue Nov 30, 2022 · 0 comments · Fixed by #272
Closed

ConnOpenAck handler verifies incorrect counterparty ConnectionId #274

plafer opened this issue Nov 30, 2022 · 0 comments · Fixed by #272
Labels
A: bug Admin: something isn't working

Comments

@plafer
Copy link
Contributor

plafer commented Nov 30, 2022

We should use the counterparty ConnectionId coming from the message rather than the one store in our store, which is guaranteed to be "" at this point in the handshake.

Identified by @kevinji.
@plafer plafer added the A: bug Admin: something isn't working label Nov 30, 2022
@plafer plafer mentioned this issue Nov 30, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: bug Admin: something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set counterparty_connection_id to None in conn_open_init
1 participant
@plafer