Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Other Item for Ics02Client,Ics03connection, Ics04Channel Error #237

Closed
5 tasks
DaviRain-Su opened this issue Nov 11, 2022 · 0 comments · Fixed by #238
Closed
5 tasks

Add Other Item for Ics02Client,Ics03connection, Ics04Channel Error #237

DaviRain-Su opened this issue Nov 11, 2022 · 0 comments · Fixed by #238

Comments

@DaviRain-Su
Copy link
Contributor

Summary

Add Other Item for Ics02Client,Ics03connection, Ics04Channel Error

Problem Definition

For downstream implementations of ibc-rs in ics02-client, ics03-connection, ics04-channel, some third-party libraries need to have their own error output, and these modules do not have an error item compatible with third-party implementations. I suggest adding an Other item to the error handling of these modules for downstream implementations to use.

Proposal

Add ics02-client, ics03-connection, ics04-channel Error module add below Other item.

define_error! {
    #[derive(Debug, PartialEq, Eq)]
    Error {
        Other 
            { description: String }
            | e | { format_args!("{}", e.description) }
   }
}

Acceptance Criteria


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant