Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChainId's epoch format should allow one-letter chain names #211

Closed
5 tasks
kevinji opened this issue Nov 3, 2022 · 0 comments · Fixed by #212
Closed
5 tasks

ChainId's epoch format should allow one-letter chain names #211

kevinji opened this issue Nov 3, 2022 · 0 comments · Fixed by #212

Comments

@kevinji
Copy link
Contributor

kevinji commented Nov 3, 2022

Summary of Bug

ChainId's epoch format disallows one-letter chain names, due to the regex beginning with .+[^-]-{1}, which requires two characters before the hyphen.

Version

v0.21.0

Steps to Reproduce

ChainId::is_epoch_format("c-1") returns false.

Acceptance Criteria

ChainId::is_epoch_format("c-1") returns true.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant