Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing check for initial consensus state in create client handler #13

Closed
5 tasks
hu55a1n1 opened this issue Aug 4, 2022 · 2 comments
Closed
5 tasks
Labels
A: bug Admin: something isn't working

Comments

@hu55a1n1
Copy link
Contributor

hu55a1n1 commented Aug 4, 2022

Summary of Bug

The create client handler is not verifying the initial consensus state. Te handler must allow the light client to decide if an initial consensus state is valid and fail otherwise.

Version

0.17.0

Acceptance Criteria

The light client is able to inspect the initial consensus state and fail the handler if it is invalid.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@hu55a1n1 hu55a1n1 added the A: bug Admin: something isn't working label Aug 4, 2022
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 28, 2022
@plafer
Copy link
Contributor

plafer commented Nov 14, 2022

We now do this right?

@hu55a1n1
Copy link
Contributor Author

Right! This was fixed in informalsystems/hermes#2483.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants