Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some problematic comment #7609

Merged
merged 1 commit into from
Nov 29, 2024
Merged

chore: fix some problematic comment #7609

merged 1 commit into from
Nov 29, 2024

Conversation

mountcount
Copy link
Contributor

@mountcount mountcount commented Nov 29, 2024 •
edited
Loading

Description

fix some problematic comment

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

gjermundgaraba
gjermundgaraba approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

@mountcount
Copy link
Contributor Author

Thank you! :)

It is my pleasure.

@srdtrk srdtrk added this pull request to the merge queue Nov 29, 2024
Merged via the queue into cosmos:main with commit 121f1fb Nov 29, 2024
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srdtrk srdtrk srdtrk approved these changes

@bznein bznein bznein approved these changes

@gjermundgaraba gjermundgaraba gjermundgaraba approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@chatton chatton Awaiting requested review from chatton chatton is a code owner

@DimitrisJim DimitrisJim Awaiting requested review from DimitrisJim DimitrisJim is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mountcount @gjermundgaraba @bznein @srdtrk