chore: add events for write ack. #7583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
requested review from
AdityaSripal,
damiannolan and
chatton
as code owners
DimitrisJim
commented
Nov 21, 2024
| @@ -205,8 +205,7 @@ func (k Keeper) WriteAcknowledgement( | |||
|
|
|||
| k.Logger(ctx).Info("acknowledgement written", "sequence", strconv.FormatUint(packet.Sequence, 10), "dest-channel", packet.DestinationChannel) | |||
|
|
|||
| // TODO: decide how relayers will reconstruct the packet as it is not being passed. | |||
| // EmitWriteAcknowledgementEvents(ctx, packet, ack) | |||
| emitWriteAcknowledgementEvents(ctx, packet, ack) | |||
|
|
|||
| // TODO: delete the packet that has been stored in ibc-core. | |||
There was a problem hiding this comment.
no issue for this exists?
DimitrisJim
force-pushed
the
jim/write-ack-events
branch
from
7b0eccf
to
0839208
Compare
DimitrisJim
commented
Nov 21, 2024
| @@ -205,8 +205,7 @@ func (k Keeper) WriteAcknowledgement( | |||
|
|
|||
| k.Logger(ctx).Info("acknowledgement written", "sequence", strconv.FormatUint(packet.Sequence, 10), "dest-channel", packet.DestinationChannel) | |||
|
|
|||
| // TODO: decide how relayers will reconstruct the packet as it is not being passed. | |||
| // EmitWriteAcknowledgementEvents(ctx, packet, ack) | |||
There was a problem hiding this comment.
we re-emit recv event here according to spec?
|
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
targets the send packet branch.
part-of: #7386
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.