From 8435e4baad909f67bfdb8cde939270a7613ad6ec Mon Sep 17 00:00:00 2001 From: Damian Nolan Date: Wed, 4 Oct 2023 14:55:01 +0200 Subject: [PATCH 1/3] chore: adding migration doc info for nil legacy subspace --- docs/docs/05-migrations/11-v7-to-v8.md | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/docs/docs/05-migrations/11-v7-to-v8.md b/docs/docs/05-migrations/11-v7-to-v8.md index c6af160e945..bfaa3c3427c 100644 --- a/docs/docs/05-migrations/11-v7-to-v8.md +++ b/docs/docs/05-migrations/11-v7-to-v8.md @@ -12,10 +12,18 @@ This guide provides instructions for migrating to version `v8.0.0` of ibc-go. There are four sections based on the four potential user groups of this document: - [Migrating from v7 to v8](#migrating-from-v7-to-v8) - - [Chains](#chains) - - [IBC Apps](#ibc-apps) - - [Relayers](#relayers) - - [IBC Light Clients](#ibc-light-clients) + - [Chains](#chains) + - [Cosmos SDK v0.50 upgrade](#cosmos-sdk-v050-upgrade) + - [Authority](#authority) + - [Testing package](#testing-package) + - [Params migration](#params-migration) + - [Governance V1 migration](#governance-v1-migration) + - [Transfer migration](#transfer-migration) + - [IBC Apps](#ibc-apps) + - [ICS20 - Transfer](#ics20---transfer) + - [ICS27 - Interchain Accounts](#ics27---interchain-accounts) + - [Relayers](#relayers) + - [IBC Light Clients](#ibc-light-clients) **Note:** ibc-go supports golang semantic versioning and therefore all imports must be updated on major version releases. @@ -138,6 +146,8 @@ Each module has a corresponding `MsgUpdateParams` message with a `Params` which Legacy params subspaces must still be initialised in app.go in order to successfully migrate from x/params to the new self-contained approach. See reference: +For new chains which do not rely on migration of parameters from `x/params`, an expected interface has been added for each module. This allows chain developers to provide `nil` as the `legacySubspace` argument to `NewKeeper` functions. + ### Governance V1 migration Proposals have been migrated to [gov v1 messages](https://docs.cosmos.network/v0.50/modules/gov#messages) ref: [#4620](https://github.com/cosmos/ibc-go/pull/4620). The proposal `ClientUpdateProposal` has been deprecated and [`MsgRecoverClient`](https://github.com/cosmos/ibc-go/blob/v8.0.0-beta.0/proto/ibc/core/client/v1/tx.proto#L121-L134) should be used instead. Likewise, the proposal `UpgradeProposal` has been deprecated and [`MsgIBCSoftwareUpgrade`](https://github.com/cosmos/ibc-go/blob/v8.0.0-beta.0/proto/ibc/core/client/v1/tx.proto#L139-L154) should be used instead. Both proposals will be removed in the next major release. From 9594a17c0f0175975fce6f6b51ee539a79ae8949 Mon Sep 17 00:00:00 2001 From: Damian Nolan Date: Wed, 4 Oct 2023 15:02:37 +0200 Subject: [PATCH 2/3] fix: lint --- docs/docs/05-migrations/11-v7-to-v8.md | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/docs/docs/05-migrations/11-v7-to-v8.md b/docs/docs/05-migrations/11-v7-to-v8.md index bfaa3c3427c..e79741d805e 100644 --- a/docs/docs/05-migrations/11-v7-to-v8.md +++ b/docs/docs/05-migrations/11-v7-to-v8.md @@ -12,18 +12,18 @@ This guide provides instructions for migrating to version `v8.0.0` of ibc-go. There are four sections based on the four potential user groups of this document: - [Migrating from v7 to v8](#migrating-from-v7-to-v8) - - [Chains](#chains) - - [Cosmos SDK v0.50 upgrade](#cosmos-sdk-v050-upgrade) - - [Authority](#authority) - - [Testing package](#testing-package) - - [Params migration](#params-migration) - - [Governance V1 migration](#governance-v1-migration) - - [Transfer migration](#transfer-migration) - - [IBC Apps](#ibc-apps) - - [ICS20 - Transfer](#ics20---transfer) - - [ICS27 - Interchain Accounts](#ics27---interchain-accounts) - - [Relayers](#relayers) - - [IBC Light Clients](#ibc-light-clients) + - [Chains](#chains) + - [Cosmos SDK v0.50 upgrade](#cosmos-sdk-v050-upgrade) + - [Authority](#authority) + - [Testing package](#testing-package) + - [Params migration](#params-migration) + - [Governance V1 migration](#governance-v1-migration) + - [Transfer migration](#transfer-migration) + - [IBC Apps](#ibc-apps) + - [ICS20 - Transfer](#ics20---transfer) + - [ICS27 - Interchain Accounts](#ics27---interchain-accounts) + - [Relayers](#relayers) + - [IBC Light Clients](#ibc-light-clients) **Note:** ibc-go supports golang semantic versioning and therefore all imports must be updated on major version releases. From b9e18f3a51da4996341aee86370f112f41738f20 Mon Sep 17 00:00:00 2001 From: Damian Nolan Date: Wed, 4 Oct 2023 15:03:41 +0200 Subject: [PATCH 3/3] fix: more indentation because --- docs/docs/05-migrations/11-v7-to-v8.md | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/docs/05-migrations/11-v7-to-v8.md b/docs/docs/05-migrations/11-v7-to-v8.md index e79741d805e..f68eea56f3c 100644 --- a/docs/docs/05-migrations/11-v7-to-v8.md +++ b/docs/docs/05-migrations/11-v7-to-v8.md @@ -13,15 +13,15 @@ There are four sections based on the four potential user groups of this document - [Migrating from v7 to v8](#migrating-from-v7-to-v8) - [Chains](#chains) - - [Cosmos SDK v0.50 upgrade](#cosmos-sdk-v050-upgrade) - - [Authority](#authority) - - [Testing package](#testing-package) - - [Params migration](#params-migration) - - [Governance V1 migration](#governance-v1-migration) - - [Transfer migration](#transfer-migration) + - [Cosmos SDK v0.50 upgrade](#cosmos-sdk-v050-upgrade) + - [Authority](#authority) + - [Testing package](#testing-package) + - [Params migration](#params-migration) + - [Governance V1 migration](#governance-v1-migration) + - [Transfer migration](#transfer-migration) - [IBC Apps](#ibc-apps) - - [ICS20 - Transfer](#ics20---transfer) - - [ICS27 - Interchain Accounts](#ics27---interchain-accounts) + - [ICS20 - Transfer](#ics20---transfer) + - [ICS27 - Interchain Accounts](#ics27---interchain-accounts) - [Relayers](#relayers) - [IBC Light Clients](#ibc-light-clients)