fix: check x/bank send enabled before escrowing fees
#2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
AdityaSripal,
charleenfei,
colin-axner and
damiannolan
as code owners
crodriguezvega
changed the title
x/bank send enabled before escrowing fees
damiannolan
approved these changes
Dec 16, 2022
chatton
approved these changes
Dec 16, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2942 +/- ##
==========================================
+ Coverage 78.55% 78.56% +0.01%
==========================================
Files 178 178
Lines 12271 12277 +6
==========================================
+ Hits 9640 9646 +6
Misses 2206 2206
Partials 425 425
|
crodriguezvega
pushed a commit
that referenced
this pull request
Dec 18, 2022
crodriguezvega
pushed a commit
that referenced
this pull request
Dec 19, 2022
crodriguezvega
pushed a commit
that referenced
this pull request
Dec 19, 2022
crodriguezvega
pushed a commit
that referenced
this pull request
Dec 19, 2022
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 27, 2023
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 31, 2023
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Commit Message / Changelog Entry
fix(statemachine)!: check x/bank send enabled before escrowing feessee the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.