Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updating migration docs with additional ics27 host parameter #2309

Conversation

damiannolan
Copy link
Member

Description

  • Adding API breaking change to migration docs for ICS27 host submodule NewKeeper function.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

+ ics4Wrapper icatypes.ICS4Wrapper,
channelKeeper icatypes.ChannelKeeper,
portKeeper icatypes.PortKeeper,
accountKeeper icatypes.AccountKeeper,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this line is a bit off. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was just looking at this. Odd, it seemed fine locally

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @damiannolan!

@damiannolan damiannolan merged commit 541a46d into carlos/#1781-create-docs-for-migration-from-v4-to-v5 Sep 20, 2022
@damiannolan damiannolan deleted the damian/update-migration-docs-v4-v5 branch September 20, 2022 13:34
crodriguezvega pushed a commit that referenced this pull request Sep 26, 2022
* wip: migration docs v4 to v5

* adding some code diffs

* adding more code snippets and diffs

* add link to docs

* fix alignment

* fix alignment

* fix alignment

* fix typo

* code improvement

* add links to sections in the document

* add migration docs for #2058

* added link to PR that renamed the ante decorator

* changes for #2083

* docs: updating migration docs with additional ics27 host parameter (#2309)

* updating migration docs with additional ics27 host parameter

* fix indentation

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
mergify bot pushed a commit that referenced this pull request Sep 26, 2022
* wip: migration docs v4 to v5

* adding some code diffs

* adding more code snippets and diffs

* add link to docs

* fix alignment

* fix alignment

* fix alignment

* fix typo

* code improvement

* add links to sections in the document

* add migration docs for #2058

* added link to PR that renamed the ante decorator

* changes for #2083

* docs: updating migration docs with additional ics27 host parameter (#2309)

* updating migration docs with additional ics27 host parameter

* fix indentation

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
(cherry picked from commit a278287)
mergify bot pushed a commit that referenced this pull request Sep 26, 2022
* wip: migration docs v4 to v5

* adding some code diffs

* adding more code snippets and diffs

* add link to docs

* fix alignment

* fix alignment

* fix alignment

* fix typo

* code improvement

* add links to sections in the document

* add migration docs for #2058

* added link to PR that renamed the ante decorator

* changes for #2083

* docs: updating migration docs with additional ics27 host parameter (#2309)

* updating migration docs with additional ics27 host parameter

* fix indentation

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
(cherry picked from commit a278287)
crodriguezvega pushed a commit that referenced this pull request Sep 26, 2022
* wip: migration docs v4 to v5

* adding some code diffs

* adding more code snippets and diffs

* add link to docs

* fix alignment

* fix alignment

* fix alignment

* fix typo

* code improvement

* add links to sections in the document

* add migration docs for #2058

* added link to PR that renamed the ante decorator

* changes for #2083

* docs: updating migration docs with additional ics27 host parameter (#2309)

* updating migration docs with additional ics27 host parameter

* fix indentation

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
(cherry picked from commit a278287)

Co-authored-by: Carlos Rodriguez <[email protected]>
damiannolan pushed a commit that referenced this pull request Sep 26, 2022
* wip: migration docs v4 to v5

* adding some code diffs

* adding more code snippets and diffs

* add link to docs

* fix alignment

* fix alignment

* fix alignment

* fix typo

* code improvement

* add links to sections in the document

* add migration docs for #2058

* added link to PR that renamed the ante decorator

* changes for #2083

* docs: updating migration docs with additional ics27 host parameter (#2309)

* updating migration docs with additional ics27 host parameter

* fix indentation

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
(cherry picked from commit a278287)

Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants