E2E: Add timeout height helper function #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
AdityaSripal,
crodriguezvega,
seantking,
charleenfei,
damiannolan and
chatton
as code owners
colin-axner
commented
Aug 11, 2022
| @@ -313,6 +314,14 @@ func (s *E2ETestSuite) getRelayerExecReporter() *testreporter.RelayerExecReporte | |||
| return rep.RelayerExecReporter(s.T()) | |||
| } | |||
|
|
|||
| // GetTimeoutHeight returns a timeout height of 1000 blocks above the current block height. | |||
| // This function should be used when the timeout is never expected to be reached | |||
| func (s *E2ETestSuite) GetTimeoutHeight(ctx context.Context, chain *cosmos.CosmosChain) clienttypes.Height { | |||
There was a problem hiding this comment.
I opened an issue to move this to the cosmos chain strangelove-ventures/interchaintest#240
chatton
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
LGTM 🥇
I think we can replace an existing call with this new function.
seantking
approved these changes
Aug 11, 2022
3 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a timeout function which returns a default timeout value to be used when sending a packet you don't want to timeout.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes