02-client refactor: fix changelog #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seantking
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan and
chatton
as code owners
|
@seantking want to merge this pr? |
Would like a look from @crodriguezvega |
crodriguezvega
suggested changes
Aug 4, 2022
There was a problem hiding this comment.
Thank you, @seantking!
I noticed that one PR is duplicated and I think can be removed.
I also noticed in the rendered file that each item of the bullet points that you added seem to have an extra line in between. Would you mind to remove it? Thanks!
| * (modules/core/02-client) [\#1189](https://github.com/cosmos/ibc-go/pull/1212) Removing `CheckMisbehaviourAndUpdateState` from `ClientState` interface & associated light client implementations. | ||
| * (modules/core/exported) [\#1206](https://github.com/cosmos/ibc-go/pull/1206) Adding new method `UpdateState` to `ClientState` interface. | ||
| * (modules/core/02-client) [\#1741](https://github.com/cosmos/ibc-go/pull/1741) Emitting a new `upgrade_chain` event upon setting upgrade consensus state. | ||
| * (client) [\#724](https://github.com/cosmos/ibc-go/pull/724) `IsRevisionFormat` and `IsClientIDFormat` have been updated to disallow newlines before the dash used to separate the chainID and revision number, and the client type and client sequence. |
There was a problem hiding this comment.
#724 was released already in v3.0.0, so I think it can just be removed from here.
There was a problem hiding this comment.
OK fixed the spacing issues good catch. It was because we added the space in between separating the client work.
There was a problem hiding this comment.
Ah, right... Thanks for fixing it!
seantking
force-pushed
the
sean/fix-changelog
branch
2 times, most recently
from
47b6896 to
cec5953
Compare
seantking
force-pushed
the
sean/fix-changelog
branch
2 times, most recently
from
8f89d3f to
27b0972
Compare
seantking
force-pushed
the
sean/fix-changelog
branch
from
27b0972 to
cd8131f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing the changelog and adding 02-client refactor work to the end of each section with two spaces between to make things easier when cutting a release later.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes