Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change non nil relayer check to non empty (backport #1774) #1790

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 27, 2022

This is an automatic backport of pull request #1774 done by Mergify.
Cherry-pick of 126ab2d has failed:

On branch mergify/bp/release/v4.0.x/pr-1774
Your branch is up to date with 'origin/release/v4.0.x'.

You are currently cherry-picking commit 126ab2d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   modules/apps/29-fee/types/errors.go
	modified:   modules/apps/29-fee/types/fee.go
	modified:   modules/apps/29-fee/types/fee_test.go
	modified:   modules/apps/29-fee/types/msgs.go
	modified:   modules/apps/29-fee/types/msgs_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* change non nil relayer check to non empty

Change relayers != nil to len(relayers) != 0
Rename ErrRelayersNotNil to ErrRelayersNotEmpty
Add test cases

* add changelog entry

(cherry picked from commit 126ab2d)

# Conflicts:
#	CHANGELOG.md
@colin-axner colin-axner self-assigned this Jul 27, 2022
@colin-axner colin-axner removed their assignment Jul 27, 2022
@damiannolan damiannolan merged commit aac882b into release/v4.0.x Jul 27, 2022
@damiannolan damiannolan deleted the mergify/bp/release/v4.0.x/pr-1774 branch July 27, 2022 17:37
ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Jul 27, 2023
…cosmos#1790)

* fix: change non nil relayer check to non empty (cosmos#1774)

* change non nil relayer check to non empty

Change relayers != nil to len(relayers) != 0
Rename ErrRelayersNotNil to ErrRelayersNotEmpty
Add test cases

* add changelog entry

(cherry picked from commit 126ab2d)

# Conflicts:
#	CHANGELOG.md

* fix changelog conflicts

Co-authored-by: colin axnér <[email protected]>
ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Jul 31, 2023
…cosmos#1790)

* fix: change non nil relayer check to non empty (cosmos#1774)

* change non nil relayer check to non empty

Change relayers != nil to len(relayers) != 0
Rename ErrRelayersNotNil to ErrRelayersNotEmpty
Add test cases

* add changelog entry

(cherry picked from commit 126ab2d)

# Conflicts:
#	CHANGELOG.md

* fix changelog conflicts

Co-authored-by: colin axnér <[email protected]>
ulbqb pushed a commit to ulbqb/ibc-go that referenced this pull request Jul 31, 2023
…cosmos#1790)

* fix: change non nil relayer check to non empty (cosmos#1774)

* change non nil relayer check to non empty

Change relayers != nil to len(relayers) != 0
Rename ErrRelayersNotNil to ErrRelayersNotEmpty
Add test cases

* add changelog entry

(cherry picked from commit 126ab2d)

# Conflicts:
#	CHANGELOG.md

* fix changelog conflicts

Co-authored-by: colin axnér <[email protected]>
@ulbqb ulbqb mentioned this pull request Jul 31, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants