Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove localhost client implementation #1187

Merged
merged 13 commits into from
Mar 31, 2022
Merged

refactor: remove localhost client implementation #1187

merged 13 commits into from
Mar 31, 2022

Conversation

seantking
Copy link
Contributor

Description

closes: #1089

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

colin-axner
colin-axner suggested changes Mar 29, 2022
View reviewed changes
modules/core/02-client/abci.go Outdated Show resolved Hide resolved
modules/core/02-client/genesis.go Show resolved Hide resolved
colin-axner
colin-axner suggested changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Migration code is needed to remove any existing localhost from state otherwise removing all the if clientID == localhost checks could be problematic. It may even result in a panic if the clientID is ever referenced from store (we would no longer be able to unmarshal the client state)

modules/core/02-client/keeper/client.go Outdated Show resolved Hide resolved
modules/core/02-client/keeper/client_test.go Show resolved Hide resolved
modules/core/02-client/keeper/keeper_test.go Show resolved Hide resolved
modules/core/module.go Outdated Show resolved Hide resolved
modules/core/02-client/types/genesis_test.go Show resolved Hide resolved
colin-axner
colin-axner reviewed Mar 31, 2022
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note, these changes are not correct until #1201 is addressed, so we should keep that in mind if we merge into 02-client-refactor

modules/core/02-client/abci_test.go Outdated Show resolved Hide resolved
modules/core/02-client/keeper/client.go Outdated Show resolved Hide resolved
colin-axner
colin-axner approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@seantking seantking enabled auto-merge (squash) March 31, 2022 12:16
@seantking seantking merged commit 5cf6528 into 02-client-refactor Mar 31, 2022
@seantking seantking deleted the sean/issue#1089-remove-localhost-client branch March 31, 2022 12:23
@colin-axner colin-axner mentioned this pull request Aug 2, 2022
Closed
seunlanlege pushed a commit to ComposableFi/ibc-go that referenced this pull request Aug 9, 2022
@seantking @seunlanlege
refactor: remove localhost client implementation (cosmos#1187)
fce284c 
* refactor: remove localhost light client implementation

* chore: readding CreateLocalhost field

* chore: readding createLocalhost field

* chore: changelog

* fix: BeginBlocker

* fix: removing CreateLocalhost

* chore: remove unused code

* refactor: keeper tests

* refactor: genesis type test add case for invalid client type

* fix: add back tests

* fix: remove unncessary if statement
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this pull request Nov 6, 2023
@dependabot
build(deps): bump golang.org/x/net from 0.14.0 to 0.15.0 (cosmos#1187)
63f6f23 
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.14.0 to
0.15.0.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/golang/net/commit/2a0da8be5a758b33fa896384d689071e832b4aa2"><code>2a0da8b</code></a>
go.mod: update golang.org/x dependencies</li>
<li><a
href="https://github.com/golang/net/commit/97384c11dd0db63357820b2cfcb44c40fbc3116a"><code>97384c1</code></a>
quic: remove streams from the conn when done</li>
<li><a
href="https://github.com/golang/net/commit/03d5e623398478fa929c8ba4b8f15de74017d82a"><code>03d5e62</code></a>
http2: remove unused ClientConn.tconnClosed</li>
<li><a
href="https://github.com/golang/net/commit/b82f062c4bc1abcfe993e3750d64c4bdd4a14f87"><code>b82f062</code></a>
quic: include ignored frames in test log output</li>
<li><a
href="https://github.com/golang/net/commit/7374d342a2c3de79d7b96f3aacdb13498c3fc3b5"><code>7374d34</code></a>
quic: don't block when closing read-only streams</li>
<li><a
href="https://github.com/golang/net/commit/b4d09be75101024ceed6b173b49a5630084174e6"><code>b4d09be</code></a>
dns/dnsmessage: compress all names while appending to a buffer</li>
<li><a
href="https://github.com/golang/net/commit/8b010a5243b670aca8d2277a3c989d1b6a198a08"><code>8b010a5</code></a>
quic: fix race condition in runAsync test helper</li>
<li><a
href="https://github.com/golang/net/commit/fe2abcb6e15f7a34d285220b437d421da4c76775"><code>fe2abcb</code></a>
quic: validate stream limits in transport params</li>
<li><a
href="https://github.com/golang/net/commit/d1b0a97d84e0fa88851b5a065e23262afed10400"><code>d1b0a97</code></a>
quic: avoid sending 1-RTT frames in initial/handshake packets</li>
<li><a
href="https://github.com/golang/net/commit/4332436fd1223b60e3127494d5ff771fba2c0adf"><code>4332436</code></a>
quic: send more transport parameters</li>
<li>Additional commits viewable in <a
href="https://github.com/golang/net/compare/v0.14.0...v0.15.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=golang.org/x/net&package-manager=go_modules&previous-version=0.14.0&new-version=0.15.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@damiannolan damiannolan damiannolan approved these changes

@fedekunze fedekunze Awaiting requested review from fedekunze

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@charleenfei charleenfei Awaiting requested review from charleenfei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seantking @damiannolan @colin-axner