Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize NextSequenceSend in ProvideCounterparty handler #7327

Closed
4 tasks
DimitrisJim opened this issue Sep 24, 2024 · 2 comments
Closed
4 tasks

Initialize NextSequenceSend in ProvideCounterparty handler #7327

DimitrisJim opened this issue Sep 24, 2024 · 2 comments

Comments

@DimitrisJim
Copy link
Contributor

Raised by @colin-axner in https://github.com/cosmos/ibc-go/pull/7174/files#r1752160538:

Lets initialize the packet sequence when setting the counterparty? This would allow us to remove the if's in send packet. I feel like calling ProvideCounterparty should be viewed as finalizing the communication details


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@damiannolan
Copy link
Contributor

We currently set the NextSequenceSend nonce in SendPacket here, where we have access to a port identifier as dictated by the application.

The ics24 path used here is the existing v1 path, which includes the port identifier. In v2/eureka, I would expect the ics24 path to not include the port id.

Currently, we do not have any port id within scope in the ProvideCounterparty rpc handler, and I would not expect there to be one.

@DimitrisJim
Copy link
Contributor Author

done in #7449

@github-project-automation github-project-automation bot moved this from Ready for Development to Done in IBC Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants