Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test that consumes forwarded memo #6663

Closed
3 tasks
DimitrisJim opened this issue Jun 20, 2024 · 2 comments · Fixed by #6707
Closed
3 tasks

Add test that consumes forwarded memo #6663

DimitrisJim opened this issue Jun 20, 2024 · 2 comments · Fixed by #6707
Assignees
@gjermundgaraba
Labels
20-transfer testing Testing package and unit/integration tests
Milestone
ICS20 v2 (path fo...

Comments

@DimitrisJim
Copy link
Contributor

It appears we currently do not have one. We should add a test that forwards a packet with populated memo and ensures that memo in final destination is present as expected.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added 20-transfer testing Testing package and unit/integration tests labels Jun 20, 2024
@DimitrisJim DimitrisJim mentioned this issue Jun 20, 2024
Merged
10 tasks
@crodriguezvega crodriguezvega moved this to Todo 🏃 in ibc-go Jun 20, 2024
@gjermundgaraba gjermundgaraba self-assigned this Jun 24, 2024
@gjermundgaraba gjermundgaraba moved this from Todo 🏃 to In progress 👷 in ibc-go Jun 25, 2024
@gjermundgaraba
Copy link
Contributor

Have the changes locally, but based off of #6691, so waiting for that to be merged before creating a PR

@gjermundgaraba gjermundgaraba mentioned this issue Jun 26, 2024
Merged
10 tasks
@gjermundgaraba gjermundgaraba linked a pull request Jun 26, 2024 that will close this issue
test: forwarding test that verifies forwarded memo #6707
Merged
10 tasks
@gjermundgaraba gjermundgaraba moved this from In progress 👷 to In review 👀 in ibc-go Jun 26, 2024
@crodriguezvega
Copy link
Contributor

Closed by #6707

@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in ibc-go Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gjermundgaraba gjermundgaraba

Labels
20-transfer testing Testing package and unit/integration tests
Projects
No open projects
ibc-go
Archived in project
Milestone
ICS20 v2 (path forwarding) beta
Development

Successfully merging a pull request may close this issue.

test: forwarding test that verifies forwarded memo cosmos/ibc-go
3 participants
@gjermundgaraba @crodriguezvega @DimitrisJim