Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept forwarding information in transfer tx CLI #6607

Closed
crodriguezvega opened this issue Jun 16, 2024 · 0 comments
Closed

Accept forwarding information in transfer tx CLI #6607

crodriguezvega opened this issue Jun 16, 2024 · 0 comments
Assignees
Labels
20-transfer CLI type: feature New features, sub-features or integrations

Comments

@crodriguezvega
Copy link
Contributor

With path forwarding we should allow users of the transfer tx CLI to enter forwarding information.

We can add a new forwarding flag with which users can enter a comma-separated list of hops (e.g transfer/channel-0,transfer/channel-1,transfer/channel-2). The CLI should parse the string into a slice of Hops (during the parsing we can validate that each hop is well formatted, i.e. the port and channel IDs are separated by a slash and both are valid identifiers).

Since we also have memo field in forwarding we could do the following: if a memo string is provided and no forwarding information is provided, then the memo string goes to the regular memo field; if forwarding information is provided, then the memo string goes to the memo field in the forwarding struct.

@crodriguezvega crodriguezvega added 20-transfer type: feature New features, sub-features or integrations CLI labels Jun 16, 2024
@crodriguezvega crodriguezvega moved this to Todo 🏃 in ibc-go Jun 16, 2024
@DimitrisJim DimitrisJim self-assigned this Jun 17, 2024
@crodriguezvega crodriguezvega moved this from Todo 🏃 to In review 👀 in ibc-go Jun 17, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in ibc-go Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-transfer CLI type: feature New features, sub-features or integrations
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants