Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result acks in token forwarding should be lightweight #6587

Closed
3 tasks
damiannolan opened this issue Jun 13, 2024 · 1 comment
Closed
3 tasks

Result acks in token forwarding should be lightweight #6587

damiannolan opened this issue Jun 13, 2024 · 1 comment
Assignees

Comments

@damiannolan
Copy link
Member

damiannolan commented Jun 13, 2024

Summary

Currently a string is used and converted to byte slice for token forwarding: []byte("forwarded packet succeeded")
This is a total of 26 bytes.

I propose maintaining parity with regular ibc transfers and storing a single byte for the result ack - since the result ack does not need to communicate any data but rather signal success.

As it exists today, osmosis db state contains something like 2.x GB of ack data on mainnet. This would be potentially upwards of 50GB if we used a similar size byte string in regular transfers.
This may seem like a small issue but at scale its impact is massive.

see thread ref: #6574 (comment)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega
Copy link
Contributor

Closed #6604

@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in ibc-go Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants