Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move decision on async handling to ibc module's OnRecv callback. #6556

Closed
3 tasks
DimitrisJim opened this issue Jun 10, 2024 · 1 comment
Closed
3 tasks
Assignees
Labels
20-transfer type: feature New features, sub-features or integrations

Comments

@DimitrisJim
Copy link
Contributor

Instead of returning boolean from Keeper OnRecvPacket to signal async ack, check if packet data in IBC module OnRecvPacket has a forwarding path.

Surfaced during internal walkthrough of ics20 v2 forwarding (commit efcfa5d)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added this to the v9.0.0 milestone Jun 10, 2024
@damiannolan
Copy link
Member

It could be nice or worth looking into to structure things within ibc_module.go something like:

// decode packet data

// keeper.OnRecvPacket()

// if data.ForwardingPath != nil { keeper.ForwardPacket() } 

But I think there's some stuff done to work coins whether they are recver source or not before forwarding, so that logic would either need to be duplicated or returned.

Otherwise, we could still sweep the forwarding logic into a priv func within keeper.

@crodriguezvega crodriguezvega added the type: feature New features, sub-features or integrations label Jun 10, 2024
@crodriguezvega crodriguezvega moved this to Todo 🏃 in ibc-go Jun 10, 2024
@gjermundgaraba gjermundgaraba self-assigned this Jun 11, 2024
@gjermundgaraba gjermundgaraba moved this from Todo 🏃 to In progress 👷 in ibc-go Jun 11, 2024
@github-project-automation github-project-automation bot moved this from In progress 👷 to Done 🥳 in ibc-go Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-transfer type: feature New features, sub-features or integrations
Projects
Archived in project
Development

No branches or pull requests

4 participants