Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend test cases to use FungibleTokenPacketDataV2 #6356

Closed
2 of 3 tasks
DimitrisJim opened this issue May 22, 2024 · 0 comments · Fixed by #6403
Closed
2 of 3 tasks

Amend test cases to use FungibleTokenPacketDataV2 #6356

DimitrisJim opened this issue May 22, 2024 · 0 comments · Fixed by #6403
Assignees
@chatton
Labels
testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
ICS20 v2 (multi d...

Comments

@DimitrisJim
Copy link
Contributor

Encountered during #6354.

We should try and amend the tests to also include some for the new format of fungible token packet data. A nice function to convert these exists in internal/convert which could be used.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added testing Testing package and unit/integration tests type: improvement User-facing improvements of an existing feature type: code hygiene Clean up code but without changing functionality or interfaces and removed type: improvement User-facing improvements of an existing feature labels May 22, 2024
@DimitrisJim DimitrisJim mentioned this issue May 22, 2024
Merged
10 tasks
@crodriguezvega crodriguezvega moved this to Todo 🏃 in ibc-go May 24, 2024
@coderabbitai coderabbitai bot mentioned this issue May 27, 2024
Merged
10 tasks
@chatton chatton self-assigned this May 28, 2024
@chatton chatton mentioned this issue May 28, 2024
Merged
10 tasks
@chatton chatton moved this from Todo 🏃 to In review 👀 in ibc-go May 28, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in ibc-go May 29, 2024
This was referenced May 30, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Archived in project
Milestone
ICS20 v2 (multi denom) RC
Development

Successfully merging a pull request may close this issue.

Add additional v2 test cases to callbacks cosmos/ibc-go
3 participants
@crodriguezvega @chatton @DimitrisJim