IBC testing code runs outside of abci lifecycle with TestChain

[damiannolan]

Summary of Bug

When actions are performs when using the ibctesting library and a msg is sent to the desired chain we generally call NextBlock on the test chain which invokes the abci callback method FinalizeBlock.

With the introduction of FinalizeBlock in abci++, the following legacy abci methods are composed into the one step:

• PreBlock (added post abci++)
• BeginBlock
• DeliverTx
• EndBlock

This means that taking action or setting up test code stubs using the current height from the chain context will yield results which do not include module actions taken on steps such as PreBlock or BeginBlock. For example, historical info at the current chain height is not stored in x/staking until BeginBlock is called. This may lead to unexpected results or test behaviour.

Expected Behaviour

Test code runs within a valid context of the abci lifecycle - e.g. the deliverTx step.

Version

main

Steps to Reproduce

See example in PR where this was caught: https://github.com/cosmos/ibc-go/pull/6018/files#r1530522751

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned