Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make router a non-pointer type on client Keeper #6010

Closed
2 of 3 tasks
DimitrisJim opened this issue Mar 15, 2024 · 1 comment
Closed
2 of 3 tasks

Make router a non-pointer type on client Keeper #6010

DimitrisJim opened this issue Mar 15, 2024 · 1 comment
Labels
02-client needs discussion Issues that need discussion before they can be worked on

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Mar 15, 2024

Reference #5806 (comment), opening to keep track as point of discussion.

We could utilize a router w/o keeping it as a pointer (currently done to keep after effects of Adding routes visible) by an alternative Get/Set router approach.

Will try and do a minor investigation pre v9 audit to see if something is stopping this change from occurring and will update issue.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added needs discussion Issues that need discussion before they can be worked on 02-client labels Mar 15, 2024
@DimitrisJim
Copy link
Contributor Author

DimitrisJim commented Mar 20, 2024

Looked into it. There's some shenanigans going on after doing this and didn't think the benefit of making it non-pointer outweighs the pain of debugging it.

If for some reason this does become an issue, we can revisit.

Closing for now, feel free to reopen if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02-client needs discussion Issues that need discussion before they can be worked on
Projects
None yet
Development

No branches or pull requests

1 participant