Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move initialization of storeProvider to light client modules #6009

Closed
2 of 3 tasks
DimitrisJim opened this issue Mar 15, 2024 · 1 comment · Fixed by #6028
Closed
2 of 3 tasks

Move initialization of storeProvider to light client modules #6009

DimitrisJim opened this issue Mar 15, 2024 · 1 comment · Fixed by #6028
Assignees
@damiannolan
Labels
02-client
Milestone
v9.0.0

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Mar 15, 2024 •
edited
Loading

Based on these two comments: #5806 (comment) and #5806 (comment). Opening to keep track as a point of discussion.

Will try to do a minor investigation pre v9 audit to see if something is stopping this change from occurring and will update issue.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added needs discussion Issues that need discussion before they can be worked on 02-client labels Mar 15, 2024
@damiannolan
Copy link
Member

Happy to discuss this, I do agree that its kind of weird to inject it via the interface method on AddRoute. It might just be cleaner to give it to client module on instantiation

@DimitrisJim DimitrisJim mentioned this issue Mar 20, 2024
Merged
10 tasks
@crodriguezvega crodriguezvega moved this to Todo 🏃 in ibc-go Jul 15, 2024
@crodriguezvega crodriguezvega added this to the v9.0.0 milestone Jul 15, 2024
@damiannolan damiannolan removed the needs discussion Issues that need discussion before they can be worked on label Jul 15, 2024
@damiannolan damiannolan moved this from Todo 🏃 to In review 👀 in ibc-go Jul 15, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in ibc-go Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
02-client
Projects
ibc-go
Archived in project
Milestone
v9.0.0
Development

Successfully merging a pull request may close this issue.

imp: pass client store provider as arg to client modules cosmos/ibc-go
3 participants
@damiannolan @crodriguezvega @DimitrisJim