Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend 08-wasm tests to only invoke SetupTest once. #5980

Open
2 of 3 tasks
DimitrisJim opened this issue Mar 13, 2024 · 0 comments
Open
2 of 3 tasks

Amend 08-wasm tests to only invoke SetupTest once. #5980

DimitrisJim opened this issue Mar 13, 2024 · 0 comments
Labels
08-wasm testing Testing package and unit/integration tests type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Mar 13, 2024 •
edited
Loading

In the current flow for the 08-wasm tests, SetupTest is invoked once during start-up of a given test and once more manually in the loop through the test cases.

We should be able to tweak these to only invoke SetupTest once and then, if a subtest requires cleanup/customization use TearDownSubTest/SetupSubTest which are invoked during suite.Run.

We could then remove the added random string appended to the wasm home dir (since we should be able to guarantee only a single app is init'ed).

Note: this could apply for other tests but haven't given a thorough look.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added testing Testing package and unit/integration tests type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. 08-wasm labels Mar 13, 2024
@DimitrisJim DimitrisJim mentioned this issue Mar 13, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
08-wasm testing Testing package and unit/integration tests type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DimitrisJim