Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error assertion for test on GetTimestampAtHeight #5964

Closed
3 tasks
colin-axner opened this issue Mar 11, 2024 · 4 comments · Fixed by #6002
Closed
3 tasks

Add error assertion for test on GetTimestampAtHeight #5964

colin-axner opened this issue Mar 11, 2024 · 4 comments · Fixed by #6002
Labels
02-client nice-to-have testing Testing package and unit/integration tests

Comments

@colin-axner
Copy link
Contributor

Summary

While reviewing #5806, I noticed that the test (which is moved to 02-client keeper tests) for GetTimestampAtHeight uses expPass instead of expError. This can be updated so the test asserts the expected error to be returned

Should be addressed after merging #5806


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the testing Testing package and unit/integration tests label Mar 11, 2024
@chandiniv1
Copy link
Contributor

@colin-axner can I work on this issue?

@colin-axner
Copy link
Contributor Author

Hi @chandiniv1, yes that would be wonderful! Can you wait until #5806 is merged into main? The test is moved around in that pr, so it will be easier to address this issue once that pr is merged

@chandiniv1
Copy link
Contributor

@colin-axner yeah it's fine. I'll wait till that issue got merged

@DimitrisJim
Copy link
Contributor

hm, seems like this is currently being addressed in #6002 as part of a slightly larger PR. Pretty sure @damiannolan just missed this issue being opened (there's been many opened as a result of the 02-client refactor and things might slip through!).

Sorry for that, plenty of other issues abound if you want to pick one up! Thanks again for the offer @chandiniv1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02-client nice-to-have testing Testing package and unit/integration tests
Projects
Status: Done 🥳
3 participants