Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable selected client types on VerifyMembership rpc #5848

Closed
3 tasks
damiannolan opened this issue Feb 15, 2024 · 0 comments · Fixed by #5871
Closed
3 tasks

Disable selected client types on VerifyMembership rpc #5848

damiannolan opened this issue Feb 15, 2024 · 0 comments · Fixed by #5871
Assignees
@damiannolan
Labels
02-client core type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
Rollkit integration

Comments

@damiannolan
Copy link
Member

Summary

We should disable the VerifyMembership rpc for specific client types.

For example

  • 06-solomachine
  • 09-localhost

See thread: #5821 (comment)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added core type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. 02-client labels Feb 15, 2024
@damiannolan damiannolan added this to the Rollkit integration milestone Feb 15, 2024
@damiannolan damiannolan moved this to Todo 🏃 in ibc-go Feb 15, 2024
@damiannolan damiannolan mentioned this issue Feb 15, 2024
Merged
9 tasks
@damiannolan damiannolan self-assigned this Feb 20, 2024
@damiannolan damiannolan moved this from Todo 🏃 to In progress 👷 in ibc-go Feb 20, 2024
@damiannolan damiannolan mentioned this issue Feb 20, 2024
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from In progress 👷 to Done 🥳 in ibc-go Feb 20, 2024
@mergify mergify bot mentioned this issue Apr 8, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
02-client core type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Archived in project
Milestone
Rollkit integration
Development

Successfully merging a pull request may close this issue.

imp: deny selected client types from VerifyMembership rpc cosmos/ibc-go
1 participant
@damiannolan