Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce usage of exported.PacketI #5745

Closed
3 tasks
colin-axner opened this issue Jan 25, 2024 · 1 comment · Fixed by #5755
Closed
3 tasks

Reduce usage of exported.PacketI #5745

colin-axner opened this issue Jan 25, 2024 · 1 comment · Fixed by #5755
Labels
type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@colin-axner
Copy link
Contributor

Summary

Throughout the codebase we reference exported.PacketI in many place we could directly reference the concrete implementation. Ideally we would remove this interface entirely as it shouldn't be necessary. As a starting point we should update reference to exported.PacketI to be channeltypes.Packet. I believe the only packet this should stay as is, is in the application callbacks, for example WriteAcknowledgement (as this may be disruptive)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the type: code hygiene Clean up code but without changing functionality or interfaces label Jan 25, 2024
@colin-axner colin-axner moved this to In review in ibc-go Jan 30, 2024
@DimitrisJim
Copy link
Contributor

follow up for WriteAcknowledgement #5774

@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

2 participants