You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Throughout the codebase we reference exported.PacketI in many place we could directly reference the concrete implementation. Ideally we would remove this interface entirely as it shouldn't be necessary. As a starting point we should update reference to exported.PacketI to be channeltypes.Packet. I believe the only packet this should stay as is, is in the application callbacks, for example WriteAcknowledgement (as this may be disruptive)
For Admin Use
Not duplicate issue
Appropriate labels applied
Appropriate contributors tagged/assigned
The text was updated successfully, but these errors were encountered:
Summary
Throughout the codebase we reference
exported.PacketI
in many place we could directly reference the concrete implementation. Ideally we would remove this interface entirely as it shouldn't be necessary. As a starting point we should update reference toexported.PacketI
to bechanneltypes.Packet
. I believe the only packet this should stay as is, is in the application callbacks, for exampleWriteAcknowledgement
(as this may be disruptive)For Admin Use
The text was updated successfully, but these errors were encountered: