When a channel reopens the ordering and metadata must not change

[crodriguezvega]

Implement this pseudocode from the spec in OnChanOpenInit of the controller:

// only open the channel if:
// - there is no active channel already set (with status OPEN)
// OR
// - there is already an active channel (with status CLOSED) AND
// the metadata matches exactly the existing metadata in the 
// version string of the active channel AND the ordering of the 
// new channel matches the ordering of the active channel.
activeChannelId, activeChannelFound = GetActiveChannelID(portId, connectionId)
if activeChannelFound {
  activeChannel = provableStore.get(channelPath(portId, activeChannelId))
  abortTransactionUnless(activeChannel.state === CLOSED)
  previousOrder = activeChannel.order
  abortTransactionUnless(previousOrder === order)
  previousMetadata = UnmarshalJSON(activeChannel.version)
  abortTransactionUnless(previousMetadata === metadata)
}

[ThanhNhann]

Can I handle this issue? And I see the link you add with OnChanOpenInit of the controller maybe wrong

[crodriguezvega]

Can I handle this issue? And I see the link you add with OnChanOpenInit of the controller maybe wrong

@ThanhNhann Thank you for the offer. The issues linked to #3996 are a bit time sensitive, since we want to include the whole feature in the release of v8.1 by the end of the month, so I think it will be better if we manage these internally. Thank you again!

[srdtrk]

Why do we want to enforce this? I'd like to allow ordering (and even encoding) to change.

[crodriguezvega]

We agreed that for v8.1 we will implement this and we can find ways to relax the restriction afterwards.

[AdityaSripal]

Given this is a highly requested feature, seems weird to me to disable and then find a way to reenable later when a solution already exists. i'd prefer to change the spec in this case

[colin-axner]

#5562 (comment)

closed by #5562