Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase MaxMemoCharLength in ICA to a higher number than 256. #5428

Closed
3 tasks
puneet2019 opened this issue Dec 16, 2023 · 3 comments · Fixed by #5442
Closed
3 tasks

Increase MaxMemoCharLength in ICA to a higher number than 256. #5428

puneet2019 opened this issue Dec 16, 2023 · 3 comments · Fixed by #5442
Assignees
Labels
27-interchain-accounts type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone

Comments

@puneet2019
Copy link

Summary

Increase MaxMemoCharLength in ICA packet data to match Transfer memo length.

Problem Definition

With coming of callbacks, memo in ICA Packet too can be used to trigger callbacks, and encoding of json might easily exceed the current limit of 256 chars

Proposal

We should take into account the memos that Transfers are using in various routers, and apply it to ICA too. 1024 seems to be a good number


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega
Copy link
Contributor

Thanks for opening the issue, @puneet2019! This sounds good to me. Maybe we could even use the same limit as the one we use for the memo field of transfer (32768).

@crodriguezvega crodriguezvega added 27-interchain-accounts type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. labels Dec 18, 2023
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Dec 18, 2023
@chandiniv1
Copy link
Contributor

@crodriguezvega can I work on this issue?

@puneet2019
Copy link
Author

@crodriguezvega Ah! thanks, I could not find memo length var before, sounds good to me :) thank you!
@chandiniv1 go ahead! reference this Issue to the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27-interchain-accounts type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants