Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to typed IBC events #54

Closed
2 of 4 tasks
colin-axner opened this issue Jul 21, 2020 · 3 comments
Closed
2 of 4 tasks

Update to typed IBC events #54

colin-axner opened this issue Jul 21, 2020 · 3 comments

Comments

@colin-axner
Copy link
Contributor

Summary

see comment.

This would ideally happen in all of the ibc module as well as the ibc-transfer module. Documentation would need to be added to the relayer guide to give example interaction with consuming the events


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@crodriguezvega
Copy link
Contributor

Looking at the Akash codebase (as mentioned in the comment linked in the description), looks like for each event we would have a type and the event would have an attribute where all the fields of the type are JSON-encoded (see example here). Do we still consider this as something we would do in the future?

@colin-axner
Copy link
Contributor Author

Personally I think we should close this issue. There hasn't been any activity on this issue nor requests to complete it, which makes me believe the events we have now work just fine

@crodriguezvega
Copy link
Contributor

Personally I think we should close this issue. There hasn't been any activity on this issue nor requests to complete it, which makes me believe the events we have now work just fine

Agree!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants