Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gov v1beta1 router from simapp #4671

Closed
3 tasks
damiannolan opened this issue Sep 15, 2023 · 2 comments · Fixed by #6798
Closed
3 tasks

Remove gov v1beta1 router from simapp #4671

damiannolan opened this issue Sep 15, 2023 · 2 comments · Fixed by #6798
Assignees
@gjermundgaraba
Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
v9.0.0

Comments

@damiannolan
Copy link
Member

damiannolan commented Sep 15, 2023 •
edited by DimitrisJim
Loading

Summary

Remove the gov v1beta1 Router from simapp/app.go (in testing, callbacks, 08-wasm) and rerun e2e upgrade test as regression.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added type: code hygiene Clean up code but without changing functionality or interfaces v8 labels Sep 15, 2023
@damiannolan damiannolan added this to the v8.0.0 milestone Sep 15, 2023
@damiannolan damiannolan moved this to Todo in ibc-go Sep 15, 2023
@chatton chatton self-assigned this Sep 19, 2023
@chatton chatton mentioned this issue Sep 19, 2023
Closed
9 tasks
@chatton chatton moved this from Todo to In progress in ibc-go Sep 19, 2023
@colin-axner colin-axner modified the milestones: v8.0.0, v9.0.0 Sep 20, 2023
@colin-axner colin-axner removed the v8 label Sep 20, 2023
@chatton chatton moved this from In progress to On hold in ibc-go Sep 20, 2023
@DimitrisJim DimitrisJim mentioned this issue Sep 21, 2023
Closed
3 tasks
@chatton
Copy link
Contributor

chatton commented Sep 21, 2023

I've closed the associated PR as we can't do this until there is a safe route to removal of proposal types: ref slack

When we do this, there will be some test refactors required, this can be used as reference.

@chatton chatton removed their assignment Nov 22, 2023
@DimitrisJim DimitrisJim added the icebox Issues that we will not address for the time being label Dec 23, 2023
@colin-axner
Copy link
Contributor

I believe it should be safe to remove the proposal types given cosmos/cosmos-sdk#17873. If a legacy proposal type is submitted and a chain upgrades, when the legacy proposal is attempted to be decoded, the proposal would fail with the above implementation

@colin-axner colin-axner removed the icebox Issues that we will not address for the time being label Jun 18, 2024
@crodriguezvega crodriguezvega moved this from On hold ❌ to Todo 🏃 in ibc-go Jul 6, 2024
@gjermundgaraba gjermundgaraba self-assigned this Jul 10, 2024
@gjermundgaraba gjermundgaraba mentioned this issue Jul 10, 2024
Merged
10 tasks
@gjermundgaraba gjermundgaraba moved this from Todo 🏃 to In review 👀 in ibc-go Jul 10, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in ibc-go Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gjermundgaraba gjermundgaraba

Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Archived in project
Milestone
v9.0.0
5 participants
@gjermundgaraba @damiannolan @chatton @DimitrisJim @colin-axner