Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and determine how to handle intertx e2e tests #4592

Closed
3 tasks
damiannolan opened this issue Sep 6, 2023 · 1 comment · Fixed by #4715
Closed
3 tasks

Cleanup and determine how to handle intertx e2e tests #4592

damiannolan opened this issue Sep 6, 2023 · 1 comment · Fixed by #4715
Assignees
@chatton
Labels
e2e testing Testing package and unit/integration tests
Milestone
v8.0.0

Comments

@damiannolan
Copy link
Member

damiannolan commented Sep 6, 2023 •
edited by colin-axner
Loading

Summary

#4590 required commenting out intertx e2e tests in order to get things passing.

Intertx requires an upgrade to v0.50 of cosmos-sdk. Or alternatively we can take a different approach towards phasing out the intertx tests.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added testing Testing package and unit/integration tests e2e labels Sep 6, 2023
@damiannolan damiannolan mentioned this issue Sep 6, 2023
Merged
9 tasks
@colin-axner colin-axner added this to the v8.0.0 milestone Sep 11, 2023
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Sep 16, 2023
@crodriguezvega crodriguezvega moved this from Todo to On hold in ibc-go Sep 18, 2023
@chatton chatton self-assigned this Sep 19, 2023
@womensrights
Copy link
Contributor

I asked around some of the existing ICA controller users and Confio, consensus is that it is fine to archive the interchain accounts demo repo so these tests can also be removed

@chatton chatton mentioned this issue Sep 19, 2023
Merged
9 tasks
@chatton chatton moved this from On hold to In review in ibc-go Sep 20, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
e2e testing Testing package and unit/integration tests
Projects
ibc-go
Archived in project
Milestone
v8.0.0
Development

Successfully merging a pull request may close this issue.

Cleanup intertx e2e tests cosmos/ibc-go
4 participants
@damiannolan @chatton @colin-axner @womensrights