Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new begin blocker interface #4559

Closed
3 tasks
colin-axner opened this issue Sep 4, 2023 · 0 comments · Fixed by #4563
Closed
3 tasks

Implement new begin blocker interface #4559

colin-axner opened this issue Sep 4, 2023 · 0 comments · Fixed by #4563
Assignees
@damiannolan @chatton
Labels
type: bug Something isn't working as expected
Milestone
v8.0.0

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Sep 4, 2023 •
edited
Loading

Summary

Begin block was made optional in v0.50 and its API changed, resulting in our BeginBlock implementations not being run. We should implement the new interface and add tests to fail if begin block functions are not run

For e2e's:

  • add start/stop to a test (maybe to genesis)
  • add assertion in localhost that height is greater than what it started (localhost is being updated)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the type: bug Something isn't working as expected label Sep 4, 2023
@colin-axner colin-axner added this to the v8.0.0 milestone Sep 4, 2023
@chatton chatton self-assigned this Sep 4, 2023
@chatton chatton mentioned this issue Sep 4, 2023
Merged
9 tasks
@damiannolan damiannolan mentioned this issue Sep 4, 2023
Merged
9 tasks
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Sep 5, 2023
@chatton chatton moved this from Todo to In review in ibc-go Sep 5, 2023
@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Sep 6, 2023
@damiannolan damiannolan self-assigned this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

@chatton chatton

Labels
type: bug Something isn't working as expected
Projects
No open projects
ibc-go
Archived in project
Milestone
v8.0.0
Development

Successfully merging a pull request may close this issue.

Implement new begin blocker interface cosmos/ibc-go
3 participants
@damiannolan @chatton @colin-axner