Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move addConnectionToClient to before setting connection in open init #45

Closed
4 tasks
colin-axner opened this issue Oct 30, 2020 · 0 comments · Fixed by #2456
Closed
4 tasks

Move addConnectionToClient to before setting connection in open init #45

colin-axner opened this issue Oct 30, 2020 · 0 comments · Fixed by #2456
Assignees
@crodriguezvega
Labels
03-connection type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
Q3-2022-backlog

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Oct 30, 2020 •
edited by crodriguezvega
Loading

Summary

The call to addConnectionToClient should be called before SetConnection in OpenInit. The state change won't be committed if the error is returned, but it is easier to read/verify when setting the connection state occurs last.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@colin-axner colin-axner transferred this issue from cosmos/cosmos-sdk Mar 4, 2021
@crodriguezvega crodriguezvega added the type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. label Jan 3, 2022
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Jan 3, 2022
faddat referenced this issue in notional-labs/ibc-go Feb 23, 2022
@ethanfrey
Merge pull request #45 from cosmwasm/vw/add-rest-server
12499ea 
Added contract state query to rest
faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
@jackzampolin @cwgoes @melekes
Merge PR #34: IBC Connection commands
053298f 
* Update to latest ibc-alpha

* Fix build

* Validate header locally

* Fetch next validator set

* Fix minor typo

* Query latest height from client state

* Debuggin 🐛 🔍 👢

* Update to latest SDK

* Merge PR #37: Play with the verifier

* Use light client API directly

* Remove all direct store access

* Add some comments and fix two-chainz

* Update to latest SDK

* Merge PR #38: verifier: update to the latest Tendermint light client

* refactor UpdateLiteDBsToLatestHeaders

* refactor GetLatestHeaders

* use channel

* close channel via defer

* update verifier to the latest lite version

ValidateBasic was removed because lite does this.

Co-authored-by: Jack Zampolin <[email protected]>

Co-authored-by: Jack Zampolin <[email protected]>
Co-authored-by: Anton Kaliaev <[email protected]>

* Update sdk version

* Update twochains to run create and update client

* Add ability to print transaction before sending

* Call ValidateBasic() on header

* Merge PR #44: Fix hanging errors

* Back to current versions of the SDK and TM, working clients, WIP connections

* New error

* Update two chains to take us to error

* Results from debugging with Chris and Aditya

* Working connection-step and expanded ci-chains test

* --pruning=nothing on ci-chains.sh

* Update upstream version

* Merge PR #45: Working Connection handshake

Co-authored-by: Christopher Goes <[email protected]>
Co-authored-by: Anton Kaliaev <[email protected]>
@crodriguezvega crodriguezvega added this to the Q2-2022-backlog milestone Mar 31, 2022
@crodriguezvega crodriguezvega self-assigned this Oct 3, 2022
@crodriguezvega crodriguezvega mentioned this issue Oct 3, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega linked a pull request Oct 3, 2022 that will close this issue
code hygiene: move call to addConnectionToClient up #2456
Merged
9 tasks
Repository owner moved this from Backlog to Done in ibc-go Oct 4, 2022
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crodriguezvega crodriguezvega

Labels
03-connection type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Archived in project
Milestone
Q3-2022-backlog
Development

Successfully merging a pull request may close this issue.

code hygiene: move call to addConnectionToClient up cosmos/ibc-go
2 participants
@crodriguezvega @colin-axner