Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create util function for upgrade plan testing #4481

Open
charleenfei opened this issue Aug 28, 2023 · 0 comments
Open

create util function for upgrade plan testing #4481

charleenfei opened this issue Aug 28, 2023 · 0 comments
Labels
testing Testing package and unit/integration tests

Comments

@charleenfei
Copy link
Contributor

charleenfei commented Aug 28, 2023 •
edited by DimitrisJim
Loading

There's probably some code magic we could do here by adding the logic to setting an old plan and checking the expected result only in the test cases that use it. Maybe we can open as a followup issue (I know this comes from the existing code). I'd expect only the test cases needing an existing plan to execute that logic (maybe by calling ibcSoftwareUpgrade with an older plan height and then having some assertion to check that the old plan exists. Happy as is though

Originally posted by @colin-axner in #4436 (comment)
@colin-axner colin-axner added the testing Testing package and unit/integration tests label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Testing package and unit/integration tests
Projects
ibc-go
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@charleenfei @colin-axner