Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend SendPacket to remove references to FlushStatus #4383

Closed
3 tasks
DimitrisJim opened this issue Aug 17, 2023 · 0 comments
Closed
3 tasks

Amend SendPacket to remove references to FlushStatus #4383

DimitrisJim opened this issue Aug 17, 2023 · 0 comments
Assignees
@DimitrisJim
Labels
04-channel channel-upgradability Channel upgradability feature
Milestone
04-channel upgrad...

Comments

@DimitrisJim
Copy link
Contributor

The current check for flush status can safely be removed given that flushing is now encoded in the channel state and is handled by the previous check of channel.State != OPEN.

Tests can be amended to remove references to flush status.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added 04-channel channel-upgradability Channel upgradability feature labels Aug 17, 2023
@DimitrisJim DimitrisJim added this to the 04-channel upgrades alpha milestone Aug 17, 2023
@DimitrisJim DimitrisJim mentioned this issue Aug 17, 2023
Merged
9 tasks
@DimitrisJim DimitrisJim moved this to In review in ibc-go Aug 17, 2023
@DimitrisJim DimitrisJim self-assigned this Aug 17, 2023
@DimitrisJim DimitrisJim moved this from In review to Done in ibc-go Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitrisJim DimitrisJim

Labels
04-channel channel-upgradability Channel upgradability feature
Projects
ibc-go
Archived in project
Milestone
04-channel upgrades alpha
Development

No branches or pull requests
1 participant
@DimitrisJim