Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RegisterLegacyAminoCodec is unused in 29-fee (should be called in module.go) #4104

Closed
3 tasks
colin-axner opened this issue Jul 17, 2023 · 1 comment · Fixed by #4812
Closed
3 tasks

RegisterLegacyAminoCodec is unused in 29-fee (should be called in module.go) #4104

colin-axner opened this issue Jul 17, 2023 · 1 comment · Fixed by #4812
Labels
needs discussion Issues that need discussion before they can be worked on type: bug Something isn't working as expected

Comments

@colin-axner
Copy link
Contributor

Summary

RegisterLegacyAminoCodec is defined in 29-fee types but is not referenced in the module.go for 29-fee. I suspect ledger signing might not work (but untested accusation)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added type: bug Something isn't working as expected needs discussion Issues that need discussion before they can be worked on labels Jul 17, 2023
@crodriguezvega
Copy link
Contributor

So the problem is that this RegisterLegacyAminoCodec function is not called in this other RegisterLegacyAminoCodec functions?

@damiannolan you wanted to do some testing with a ledger for #4570, right? Would it be possible for you to check if @colin-axner's hypothesis is correct? If it doesn't work then we can open a quick PR to fix it.

@damiannolan damiannolan mentioned this issue Oct 17, 2023
Merged
9 tasks
@github-project-automation github-project-automation bot moved this to Done in ibc-go Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs discussion Issues that need discussion before they can be worked on type: bug Something isn't working as expected
Projects
ibc-go
Status: Done 🥳
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fixes for legacy amino encoding for ledger signing cosmos/ibc-go
2 participants
@crodriguezvega @colin-axner