Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove params subspaces in simapp for sdk modules after v7 #3141

Closed
3 tasks
damiannolan opened this issue Feb 14, 2023 · 0 comments · Fixed by #3182
Closed
3 tasks

Remove params subspaces in simapp for sdk modules after v7 #3141

damiannolan opened this issue Feb 14, 2023 · 0 comments · Fixed by #3182
Assignees
@damiannolan
Labels
e2e testing Testing package and unit/integration tests
Milestone
v7.1.0

Comments

@damiannolan
Copy link
Member

Summary

The x/params module has been deprecated in SDK v0.47.
Standard SDK modules included in the ibc-go simapp have now migrated params to be managed directly by the module.

In ibc-go v7.1.0 we can remove the subspaces and keytable registration for standard SDK modules which now maintain params within their own module state.

We must continue to create params subspaces for ibc-go application modules until params are migrated.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added testing Testing package and unit/integration tests e2e labels Feb 14, 2023
@damiannolan damiannolan mentioned this issue Feb 14, 2023
Merged
9 tasks
@damiannolan damiannolan moved this to Todo in ibc-go Feb 14, 2023
@damiannolan damiannolan added this to the v7.1.0 milestone Feb 14, 2023
@damiannolan damiannolan mentioned this issue Feb 21, 2023
Merged
9 tasks
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Feb 21, 2023
@damiannolan damiannolan self-assigned this Feb 21, 2023
@damiannolan damiannolan moved this from In progress to In review in ibc-go Feb 21, 2023
@github-project-automation github-project-automation bot moved this from In review to Todo in ibc-go Feb 22, 2023
@damiannolan damiannolan moved this from Todo to Done in ibc-go Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
e2e testing Testing package and unit/integration tests
Projects
ibc-go
Archived in project
Milestone
v7.1.0
Development

Successfully merging a pull request may close this issue.

chore: removing legacy params subspaces for sdk modules cosmos/ibc-go
1 participant
@damiannolan