Fix E2E Memo test for broken versions

[chatton]

Summary of Bug

depends on #3026

The TestMsgTransfer_WithMemo is failing in certain configurations. See the following workflow to see the full failures.

The failing tests seem to all have this error:

RPC error -32603 - Internal error: tx (2F4F8F5D2FA006F9329153C4736CFEDC9F65924E6A5EC33E63065A310837D86D) not found

Expected Behaviour

The test should account for these versions and should pass.

Version

The following table shows which tests are broken.

Chain A	Chain B	Result
main	v4.1.1	PASS
main	v3.3.1	PASS
main	v2.4.2	PASS
main	v5.0.1	PASS
v4.1.1	main	FAIL
v3.3.1	main	FAIL
v2.4.2	main	FAIL
v5.0.1	main	FAIL

Steps to Reproduce

Run the TestMsgTransfer_WithMemo with any of these versions.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned

[chatton]

It looks like this is an issue with how the cosmos.BroadcastTx function works. We are discarding the tx response if the authtx query fails, which it will in the case of an unknown field. The test passing locally when updating the function in ibctest to

func BroadcastTx(ctx context.Context, broadcaster *Broadcaster, broadcastingUser
        }

        err = testutil.WaitForCondition(time.Second*30, time.Second*5, func() (bool, error) {
-               _, err := broadcaster.GetTxResponseBytes(ctx, broadcastingUser)
+               var err error
+               txBytes, err = broadcaster.GetTxResponseBytes(ctx, broadcastingUser)
                if err != nil {
                        return false, nil
                }
@@ -217,11 +218,6 @@ func BroadcastTx(ctx context.Context, broadcaster *Broadcaster, broadcastingUser
                return sdk.TxResponse{}, err
        }

-       txBytes, err = broadcaster.GetTxResponseBytes(ctx, broadcastingUser)
-       if err != nil {
-               return sdk.TxResponse{}, err
-       }
-
        respWithTxHash, err := broadcaster.UnmarshalTxResponseBytes(ctx, txBytes)
        if err != nil {
                return sdk.TxResponse{}, err
@@ -229,8 +225,13 @@ func BroadcastTx(ctx context.Context, broadcaster *Broadcaster, broadcastingUser

        resp, err := authTx.QueryTx(cc, respWithTxHash.TxHash)
        if err != nil {
-               return sdk.TxResponse{}, err
+               // if we fail to query the tx, it means an error occurred with the original message broadcast.
+               // we should return this instead.
+               originalResp, err := broadcaster.UnmarshalTxResponseBytes(ctx, txBytes)
+               if err != nil {
+                       return sdk.TxResponse{}, err
+               }
+               return originalResp, nil
        }
-
        return *resp, nil
 }

We can wait for the sdk 47 PR to get merged in ibc test before making these changes. I don't think this is a big priority anymore as this confirms that the test still works, it was just an issue with the broadcast function.

[chatton]

I created a PR against the sdk 47 branch here