Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authz/ics20: unit tests for ValidateBasic method of TransferAuthorization #2963

Closed
crodriguezvega opened this issue Dec 21, 2022 · 1 comment
Closed

authz/ics20: unit tests for ValidateBasic method of TransferAuthorization #2963

crodriguezvega opened this issue Dec 21, 2022 · 1 comment
Assignees
@damiannolan
Labels
20-transfer testing Testing package and unit/integration tests
Milestone
v7.0.0

Comments

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Dec 21, 2022 •
edited
Loading

Unit tests for the following scenarios:

  • Validation should fail if for any allocation in TransferAuthorization when:

    • spend_limit is nil.
    • Any of the coins in spend_limit is not valid.
    • Either the source port or source channel is not a valid identifier.
    • There are more than one allocations AND the same source port and source channel combination is present in more than one allocation.
    • The allow_list for an allocation contains duplicate addresses.

  • Validation should succeed when:

    • There are one or more allocations AND spend_limit is not nil and all coins are valid AND source port and source channel are valid identifiers AND source port/source channel combination is not duplicated AND allow_list is either empty or does not contain duplicate addresses.

Open PRs against the feature branch.
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Dec 21, 2022
@crodriguezvega crodriguezvega added this to the v7.0.0 milestone Dec 21, 2022
@crodriguezvega crodriguezvega added the testing Testing package and unit/integration tests label Dec 21, 2022
@damiannolan damiannolan self-assigned this Jan 10, 2023
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Jan 10, 2023
@damiannolan damiannolan mentioned this issue Jan 10, 2023
Merged
9 tasks
@chatton chatton moved this from In progress to Done in ibc-go Jan 13, 2023
@damiannolan
Copy link
Member

closed by #2992

@github-project-automation github-project-automation bot moved this from Done to Todo in ibc-go Jan 16, 2023
@damiannolan damiannolan moved this from Todo to Done in ibc-go Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
20-transfer testing Testing package and unit/integration tests
Projects
ibc-go
Status: Done 🥳
Milestone
v7.0.0
Development

No branches or pull requests
2 participants
@damiannolan @crodriguezvega