Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup 03-connection msg validate basic test #2747

Closed
3 tasks
colin-axner opened this issue Nov 14, 2022 · 2 comments · Fixed by #3244
Closed
3 tasks

Cleanup 03-connection msg validate basic test #2747

colin-axner opened this issue Nov 14, 2022 · 2 comments · Fixed by #3244
Assignees
Labels
good first issue Good for newcomers testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Nov 14, 2022

Summary

TestNewMsgConnectionOpenConfirm is not very ergonomic. It should be restructured to combine the msgs into the test cases:

testCases := []struct {
		name    string
		msg     *types.MsgConnectionOpenTry
		expPass bool
}{

exactly the same as the other test cases in the same file.

  1. put the test case name first
  2. move testMsgs into the test case struct
  3. set expPass bool last

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces good first issue Good for newcomers labels Nov 14, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Feb 20, 2023
@crodriguezvega crodriguezvega self-assigned this Feb 20, 2023
@expertdicer
Copy link
Contributor

Can you pls review my changes? Thank you

@crodriguezvega
Copy link
Contributor

Can you pls review my changes? Thank you

Sorry for the late reply, but yes, definitely! Thanks for opening quickly a PR!

@crodriguezvega crodriguezvega moved this from Todo to In review in ibc-go Mar 7, 2023
@github-project-automation github-project-automation bot moved this from In review to Todo in ibc-go Mar 8, 2023
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants