Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update buf usage for sdk 0.47 #2671

Closed
tac0turtle opened this issue Nov 3, 2022 · 3 comments · Fixed by #2672
Closed

update buf usage for sdk 0.47 #2671

tac0turtle opened this issue Nov 3, 2022 · 3 comments · Fixed by #2672
Assignees
@damiannolan
Milestone
SDK v0.47.x upgrade

Comments

@tac0turtle
Copy link
Member

Summary of Bug

please update your bus usage to follow sdk conventions. The version used in ibc is very old.
@tac0turtle tac0turtle changed the title update but usage update buf usage Nov 3, 2022
@tac0turtle
Copy link
Member Author

proto docs were deprecated as well. should migrate to but system so other teams can import your proto definitions without needing to copy paste the files

@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Nov 3, 2022
@damiannolan
Copy link
Contributor

Thanks for opening this, I strongly agree. Will try to get this prioritised

@damiannolan damiannolan self-assigned this Nov 8, 2022
@damiannolan damiannolan moved this from Backlog to In progress in ibc-go Nov 8, 2022
@damiannolan damiannolan mentioned this issue Nov 8, 2022
Merged
9 tasks
@damiannolan damiannolan moved this from In progress to In review in ibc-go Nov 9, 2022
@damiannolan
Copy link
Contributor

See #2705 for details on updating buf for sdk 0.47

@damiannolan damiannolan changed the title update buf usage update buf usage for sdk 0.47 Nov 10, 2022
@damiannolan damiannolan moved this from In review to Todo in ibc-go Dec 5, 2022
@crodriguezvega crodriguezvega added this to the SDK v0.47.x upgrade milestone Dec 12, 2022
@damiannolan damiannolan mentioned this issue Dec 12, 2022
Merged
9 tasks
@damiannolan damiannolan moved this from Todo to On hold in ibc-go Dec 22, 2022
@github-project-automation github-project-automation bot moved this from On hold to Todo in ibc-go Jan 13, 2023
@damiannolan damiannolan moved this from Todo to Done in ibc-go Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
None yet
Projects
No open projects
ibc-go
Status: Done 🥳
Milestone
SDK v0.47.x upgrade
Development

Successfully merging a pull request may close this issue.

chore: update to 0.47 cosmos/ibc-go
3 participants
@damiannolan @crodriguezvega @tac0turtle