Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port prefix check on the ICA host prevents the implementation of a controller directly into a smart contract #2580

Closed
3 tasks
charleenfei opened this issue Oct 25, 2022 · 1 comment · Fixed by #2590

Comments

@charleenfei
Copy link
Contributor

Summary

context from user on Discord:

...in the ICA spec, the controller port has to be prefixed with 'ica-controller'. If this prefix requirement wouldn't be there, it's quite straightforward to write a cosmwasm contract that can connect to an icahost without the need for an ica controller on the controller chain.

Problem Definition

Proposal

we should be able to remove the check on host side without significantly affecting security properties. considerations were around accidental name collisions, iteration on port identifiers within a given namespace.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@ethanfrey
Copy link
Contributor

I fully support this, we should be port agnostic as much as possible.

There was the same issue with ibctransfer module before that would only connect to transfer port on the other side. See cosmos/ibc#463

@charleenfei charleenfei moved this from Todo to In review in ibc-go Oct 26, 2022
@charleenfei charleenfei moved this from In review to Todo in ibc-go Oct 26, 2022
@charleenfei charleenfei moved this from Todo to In review in ibc-go Oct 26, 2022
Repository owner moved this from In review to Done in ibc-go Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants