Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: adding simd controller msg server tests #2572

Merged
merged 13 commits into from
Oct 26, 2022

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Oct 24, 2022

Description

The existing e2e tests for ics27 rely on the intertx module and icad binary.
With the addition of the controller MsgServer we should also cover that execution path, which can be done using simd.

  • Adding e2e tests for interchain accounts controller MsgServer
  • Move intertx tests to separate files
  • Update workflows to accommodate renaming and include new interchain accounts tests

I have created an issue below to track legacy code which can be removed when ibc-go/v5 reaches end-of-life.
Please feel free to add anything to this which is necessary.

Manual icad workflow runs using the new InterTxTestSuite and IncentivizedInterTxTestSuite:


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 💚 All the workflow changes look good to me. Happy to get this merged once we've confirmed that all the tests pass when manually triggering them from this branch.

🥇

@damiannolan
Copy link
Member Author

I just spotted the incorrect struct was embedded in the IncentivizedInterTxTestSuite. Updated and will let workflows complete before merging

@damiannolan damiannolan enabled auto-merge (squash) October 26, 2022 13:20
@damiannolan damiannolan merged commit eebe2a1 into main Oct 26, 2022
@damiannolan damiannolan deleted the damian/e2e-ics27-controller-simd branch October 26, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants