Errors when using NewTestChain with custom app

[migueldingli1997]

Summary of Bug

Custom (or third-party) app expected to be an ibc-go SimApp when the GetSimApp function is called as a result of using the NewTestChainWithValSet function. In my scenario, this expectations is leading to errors when using NewTestChain to create a custom chain after overriding ibctesting.DefaultTestingAppInit as pointed out in the documentation. The NewTestChain function works just fine with the default DefaultTestingAppInit (i.e. no override).

Just for a bit of extra context, I first encountered this error in the process of upgrading my custom chain from v3 to v5 of ibc-go. Seems like that call to GetSimApp was introduced in v4 of ibc-go.

Expected Behaviour

I expect to be able to create a test chain using the NewTestChain function with a custom app.

Version

v5.0.0-rc1

Steps to Reproduce

Calling NewTestChain with a custom app should be enough to trigger the error.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned

[damiannolan]

Hey @migueldingli1997, could you try with v5.0.0-rc2?

The code you point to has been removed, see: #2148

[migueldingli1997]

Hey @migueldingli1997, could you try with v5.0.0-rc2?

The code you point to has been removed, see: #2148

That works, thank you! I will close this issue.