chore: ics27 middleware callback routing #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
commented
Aug 31, 2022
Comment on lines
20
to
30
| channelID, err := k.registerInterchainAccount(ctx, connectionID, owner, version) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| portID, err := icatypes.NewControllerPortID(owner) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| k.SetMiddlewareEnabled(ctx, portID, channelID) |
There was a problem hiding this comment.
Thinking about change the signature of the private func registerInterchainAccount and having this func and the msg server func generate the port ID.
Thoughts?
There was a problem hiding this comment.
I don't have a preference. Whatever you think is best
damiannolan
requested review from
seantking,
AdityaSripal,
crodriguezvega,
charleenfei and
chatton
as code owners
colin-axner
reviewed
Aug 31, 2022
modules/apps/27-interchain-accounts/controller/keeper/keeper.go
Outdated
Show resolved
Hide resolved
seantking
approved these changes
Aug 31, 2022
…go into damian/2145-ics27-cb-routing
Co-authored-by: colin axnér <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Aug 31, 2022
* [WIP] add middleware enabled flags and conditional logic * adapting private registerInterchainAccount func to accept portID in favour of owner * updating tests * cleaning up tests * adding changelog * updating tests: adding cbs with unreachable error returns for safety * Update modules/apps/27-interchain-accounts/controller/keeper/keeper.go Co-authored-by: colin axnér <[email protected]> Co-authored-by: colin axnér <[email protected]> (cherry picked from commit dda9f98) # Conflicts: # CHANGELOG.md # modules/apps/27-interchain-accounts/controller/ibc_middleware.go
damiannolan
added a commit
that referenced
this pull request
Sep 6, 2022
* chore: ics27 middleware callback routing (#2157) * [WIP] add middleware enabled flags and conditional logic * adapting private registerInterchainAccount func to accept portID in favour of owner * updating tests * cleaning up tests * adding changelog * updating tests: adding cbs with unreachable error returns for safety * Update modules/apps/27-interchain-accounts/controller/keeper/keeper.go Co-authored-by: colin axnér <[email protected]> Co-authored-by: colin axnér <[email protected]> (cherry picked from commit dda9f98) # Conflicts: # CHANGELOG.md # modules/apps/27-interchain-accounts/controller/ibc_middleware.go * resolvning conflicts Co-authored-by: Damian Nolan <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IsMiddlewareEnabledkeeper functions, key prefix and functions.SetMiddlewareEnabledwhen ICS27 account is registered via the legacy go API -RegisterInterchainAccountMsgservice do not invoke the underlying application callbackscloses: #2145
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes