Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBC testing package GetStakingKeeper change needs migation docs entry #2083

Closed
3 tasks
colin-axner opened this issue Aug 23, 2022 · 0 comments · Fixed by #1826
Closed
3 tasks

IBC testing package GetStakingKeeper change needs migation docs entry #2083

colin-axner opened this issue Aug 23, 2022 · 0 comments · Fixed by #1826
Assignees
@crodriguezvega
Labels
docs Improvements or additions to documentation
Milestone
v5.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

Add an entry to the migration docs explaining and linking the changes in #2028. Please link the simapp/app.go changes in diff view to the entry

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega added this to the v5.0.0 milestone Sep 5, 2022
@crodriguezvega crodriguezvega added the docs Improvements or additions to documentation label Sep 5, 2022
@crodriguezvega crodriguezvega self-assigned this Sep 5, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Sep 5, 2022
crodriguezvega pushed a commit that referenced this issue Sep 12, 2022
changes for #2083
7783fac
@crodriguezvega crodriguezvega mentioned this issue Sep 12, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega moved this from Todo to In review in ibc-go Sep 16, 2022
crodriguezvega pushed a commit that referenced this issue Sep 26, 2022
@colin-axner @damiannolan
docs: migration docs v4 to v5 (#1826)
a278287 
* wip: migration docs v4 to v5

* adding some code diffs

* adding more code snippets and diffs

* add link to docs

* fix alignment

* fix alignment

* fix alignment

* fix typo

* code improvement

* add links to sections in the document

* add migration docs for #2058

* added link to PR that renamed the ante decorator

* changes for #2083

* docs: updating migration docs with additional ics27 host parameter (#2309)

* updating migration docs with additional ics27 host parameter

* fix indentation

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
Repository owner moved this from In review to Done in ibc-go Sep 26, 2022
mergify bot pushed a commit that referenced this issue Sep 26, 2022
@mergify
docs: migration docs v4 to v5 (#1826)
89ec0e2 
* wip: migration docs v4 to v5

* adding some code diffs

* adding more code snippets and diffs

* add link to docs

* fix alignment

* fix alignment

* fix alignment

* fix typo

* code improvement

* add links to sections in the document

* add migration docs for #2058

* added link to PR that renamed the ante decorator

* changes for #2083

* docs: updating migration docs with additional ics27 host parameter (#2309)

* updating migration docs with additional ics27 host parameter

* fix indentation

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
(cherry picked from commit a278287)
mergify bot pushed a commit that referenced this issue Sep 26, 2022
@mergify
docs: migration docs v4 to v5 (#1826)
5146d1a 
* wip: migration docs v4 to v5

* adding some code diffs

* adding more code snippets and diffs

* add link to docs

* fix alignment

* fix alignment

* fix alignment

* fix typo

* code improvement

* add links to sections in the document

* add migration docs for #2058

* added link to PR that renamed the ante decorator

* changes for #2083

* docs: updating migration docs with additional ics27 host parameter (#2309)

* updating migration docs with additional ics27 host parameter

* fix indentation

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
(cherry picked from commit a278287)
crodriguezvega pushed a commit that referenced this issue Sep 26, 2022
@mergify
docs: migration docs v4 to v5 (#1826) (#2385)
64269cc 
* wip: migration docs v4 to v5

* adding some code diffs

* adding more code snippets and diffs

* add link to docs

* fix alignment

* fix alignment

* fix alignment

* fix typo

* code improvement

* add links to sections in the document

* add migration docs for #2058

* added link to PR that renamed the ante decorator

* changes for #2083

* docs: updating migration docs with additional ics27 host parameter (#2309)

* updating migration docs with additional ics27 host parameter

* fix indentation

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
(cherry picked from commit a278287)

Co-authored-by: Carlos Rodriguez <[email protected]>
damiannolan pushed a commit that referenced this issue Sep 26, 2022
@mergify
docs: migration docs v4 to v5 (#1826) (#2386)
c1113f8 
* wip: migration docs v4 to v5

* adding some code diffs

* adding more code snippets and diffs

* add link to docs

* fix alignment

* fix alignment

* fix alignment

* fix typo

* code improvement

* add links to sections in the document

* add migration docs for #2058

* added link to PR that renamed the ante decorator

* changes for #2083

* docs: updating migration docs with additional ics27 host parameter (#2309)

* updating migration docs with additional ics27 host parameter

* fix indentation

Co-authored-by: colin axnér <[email protected]>
Co-authored-by: Damian Nolan <[email protected]>
(cherry picked from commit a278287)

Co-authored-by: Carlos Rodriguez <[email protected]>
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crodriguezvega crodriguezvega

Labels
docs Improvements or additions to documentation
Projects
ibc-go
Status: Done 🥳
Milestone
v5.0.0
Development

Successfully merging a pull request may close this issue.

docs: migration docs v4 to v5 cosmos/ibc-go
2 participants
@crodriguezvega @colin-axner