Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ics27 e2e test with governance #2063

Closed
3 tasks
colin-axner opened this issue Aug 22, 2022 · 3 comments · Fixed by #2808
Closed
3 tasks

Add ics27 e2e test with governance #2063

colin-axner opened this issue Aug 22, 2022 · 3 comments · Fixed by #2808
Assignees
@damiannolan @chatton
Labels
27-interchain-accounts e2e
Milestone
v6.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

Add an e2e test with ics27 using governance as the authorization method. Low priority

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Aug 22, 2022
@crodriguezvega crodriguezvega added this to the v5.1.0 milestone Aug 22, 2022
@colin-axner colin-axner mentioned this issue Aug 31, 2022
Merged
9 tasks
@chatton chatton self-assigned this Sep 5, 2022
@chatton
Copy link
Contributor

chatton commented Sep 8, 2022 •
edited
Loading

It looks like this is not actually possible using the new governance module. See this slack thread.

From the slack thread this pr and the gov module docs

@chatton chatton removed their assignment Sep 23, 2022
@chatton
Copy link
Contributor

chatton commented Oct 28, 2022

It looks like this issue is preventing the full flow to work as events are not being emitted correctly once the governance proposal passes. thank you @damiannolan for all the help investigating this issue ❤️

@damiannolan damiannolan moved this from Todo to On hold in ibc-go Oct 31, 2022
@crodriguezvega crodriguezvega moved this to On hold in ibc-go Nov 1, 2022
@okwme
Copy link

okwme commented Nov 2, 2022

Fix is included in https://github.com/cosmos/cosmos-sdk/releases/tag/v0.46.4

@crodriguezvega crodriguezvega moved this from On hold to In progress in ibc-go Nov 21, 2022
@chatton chatton mentioned this issue Nov 22, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega moved this from In progress to In review in ibc-go Nov 22, 2022
Repository owner moved this from In review to Todo in ibc-go Nov 23, 2022
@colin-axner colin-axner moved this from Todo to Done in ibc-go Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

@chatton chatton

Labels
27-interchain-accounts e2e
Projects
ibc-go
Status: Done 🥳
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

Add ICS27 e2e test with governance cosmos/ibc-go
5 participants
@okwme @damiannolan @crodriguezvega @chatton @colin-axner