Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for how to integrate external light clients to a chain #2008

Closed
3 tasks
colin-axner opened this issue Aug 15, 2022 · 1 comment · Fixed by #2905
Closed
3 tasks

Add documentation for how to integrate external light clients to a chain #2008

colin-axner opened this issue Aug 15, 2022 · 1 comment · Fixed by #2905
Assignees
Labels
docs Improvements or additions to documentation

Comments

@colin-axner
Copy link
Contributor

Summary

We should have documentation explaining how external light clients can be integrated into a chain


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added the docs Improvements or additions to documentation label Aug 15, 2022
@colin-axner colin-axner added this to the 02-client refactor RC milestone Aug 15, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Aug 15, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Nov 1, 2022
@colin-axner
Copy link
Contributor Author

Consider applying the suggestion here #2825 (comment)

We could move all the ibc registration to the bottom of the stack and then add lines of comments for registering our client types

ModuleBasics = module.NewBasicManager(
    ...
    ibc.AppModuleBasic{},
    
    // register light clients on IBC
    ibctm.AppModuleBasic{},
    solomachine.AppModuleBasic{},
}

@chatton chatton self-assigned this Dec 7, 2022
@chatton chatton moved this from Todo to In progress in ibc-go Dec 8, 2022
Repository owner moved this from In progress to Todo in ibc-go Dec 12, 2022
@damiannolan damiannolan moved this from Todo to Done in ibc-go Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

2 participants